Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(jest): Final Jest cleanup #15549

Merged
merged 9 commits into from
Mar 26, 2025
Merged

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Mar 1, 2025

resolves #11084

Finally clears up the remaining references to Jest.

These PRs need merging first:

@AbhiPrasad AbhiPrasad force-pushed the timfish/test/jest-final-cleanup branch from d249b7e to 516bbca Compare March 25, 2025 23:18
@AbhiPrasad AbhiPrasad marked this pull request as ready for review March 25, 2025 23:18
@AbhiPrasad AbhiPrasad self-assigned this Mar 25, 2025
@AbhiPrasad AbhiPrasad enabled auto-merge (squash) March 25, 2025 23:19
@AbhiPrasad
Copy link
Member

There's a couple more references to jest, but we can slowly clean that up over time. I'll create GH issues for them.

For now let's just try to get this merged in because I really want to get #11084 closed - we've been working toward it for so long.

@AbhiPrasad
Copy link
Member

dang still some stuff left to clean up - @timfish feel free to take a look if you have time, otherwise I'll try to finish this up tomorrow morning

@AbhiPrasad AbhiPrasad merged commit c38315e into develop Mar 26, 2025
151 of 152 checks passed
@AbhiPrasad AbhiPrasad deleted the timfish/test/jest-final-cleanup branch March 26, 2025 05:39
@timfish
Copy link
Collaborator Author

timfish commented Mar 26, 2025

The solidjs tests still needed @testing-library/jest-dom for expect(something).toBeInTheDocument() to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate from jest to vitest and stop using jsdom based tests
2 participants