Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Stop using dropUndefinedKeys #15796

Merged
merged 5 commits into from
Mar 25, 2025
Merged

feat: Stop using dropUndefinedKeys #15796

merged 5 commits into from
Mar 25, 2025

Conversation

mydea
Copy link
Member

@mydea mydea commented Mar 24, 2025 •
edited
Loading

This removes the last remaining usages of dropUndefinedKeys in the SDK.

It also deprecates the export from @sentry/core for future removal.

@mydea mydea requested review from lforst and chargome March 24, 2025 12:29
@mydea mydea self-assigned this Mar 24, 2025
@mydea mydea requested a review from a team as a code owner March 24, 2025 12:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 24, 2025 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.08 KB -0.58% -137 B 🔽
@sentry/browser - with treeshaking flags 22.88 KB -0.59% -139 B 🔽
@sentry/browser (incl. Tracing) 36.49 KB -0.34% -126 B 🔽
@sentry/browser (incl. Tracing, Replay) 73.66 KB -0.18% -131 B 🔽
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.03 KB -0.12% -81 B 🔽
@sentry/browser (incl. Tracing, Replay with Canvas) 78.3 KB -0.16% -123 B 🔽
@sentry/browser (incl. Tracing, Replay, Feedback) 90.88 KB -0.14% -127 B 🔽
@sentry/browser (incl. Feedback) 40.21 KB -0.31% -127 B 🔽
@sentry/browser (incl. sendFeedback) 27.71 KB -0.5% -142 B 🔽
@sentry/browser (incl. FeedbackAsync) 32.5 KB -0.39% -129 B 🔽
@sentry/react 24.88 KB -0.51% -129 B 🔽
@sentry/react (incl. Tracing) 38.38 KB -0.34% -133 B 🔽
@sentry/vue 27.3 KB -0.5% -138 B 🔽
@sentry/vue (incl. Tracing) 38.17 KB -0.32% -124 B 🔽
@sentry/svelte 23.12 KB -0.55% -129 B 🔽
CDN Bundle 24.32 KB -0.46% -113 B 🔽
CDN Bundle (incl. Tracing) 36.5 KB -0.35% -131 B 🔽
CDN Bundle (incl. Tracing, Replay) 71.5 KB -0.17% -119 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) 76.7 KB -0.17% -128 B 🔽
CDN Bundle - uncompressed 70.97 KB -0.59% -425 B 🔽
CDN Bundle (incl. Tracing) - uncompressed 108.16 KB -0.39% -430 B 🔽
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.41 KB -0.2% -434 B 🔽
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 231.97 KB -0.19% -434 B 🔽
@sentry/nextjs (client) 39.68 KB -0.32% -130 B 🔽
@sentry/sveltekit (client) 36.9 KB -0.35% -131 B 🔽
@sentry/node 142.48 KB -0.09% -130 B 🔽
@sentry/node - without tracing 95.87 KB -0.13% -126 B 🔽
@sentry/aws-serverless 120.21 KB -0.12% -142 B 🔽

View base workflow run

@mydea mydea force-pushed the fn/drop-even-more-undefinedKeys branch from 0717bb5 to 5e441a7 Compare March 24, 2025 12:40
@mydea mydea force-pushed the fn/drop-even-more-undefinedKeys branch from 5e441a7 to 0869503 Compare March 24, 2025 13:10
@mydea mydea changed the title ref: Refactor some more dropUndefinedKeys ref: Stop using dropUndefinedKeys Mar 24, 2025
@mydea mydea changed the title ref: Stop using dropUndefinedKeys feat: Stop using dropUndefinedKeys Mar 24, 2025
@mydea mydea mentioned this pull request Mar 24, 2025
Closed
3 tasks
chargome
chargome reviewed Mar 24, 2025
View reviewed changes
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also deprecates the export from @sentry/core for future removal.

I think this one is still missing?

@mydea
Copy link
Member Author

mydea commented Mar 25, 2025

It also deprecates the export from @sentry/core for future removal.

I think this one is still missing?

oops, I added this, forgot to push it before 😅

@mydea mydea merged commit 7f1087d into develop Mar 25, 2025
152 checks passed
@mydea mydea deleted the fn/drop-even-more-undefinedKeys branch March 25, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lms24 Lms24 Lms24 left review comments

@chargome chargome chargome left review comments

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@lforst lforst Awaiting requested review from lforst

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mydea @Lms24 @AbhiPrasad @chargome