test: Add browser integration tests for logs #15815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
stephanie-anderson and
s1gr1d
and removed request for
a team
7 tasks
s1gr1d
reviewed
Mar 25, 2025
| Sentry.logger.warn('test warn'); | ||
| Sentry.logger.error('test error'); | ||
| Sentry.logger.fatal('test fatal'); | ||
| Sentry.logger.critical('test critical'); |
There was a problem hiding this comment.
Should we maybe also test the overloaded functions here?
There was a problem hiding this comment.
Overloaded functions only exist in Node
But we should test parameterization, I can add those!
AbhiPrasad
force-pushed
the
abhi-browser-logs-integration
branch
from
7119971 to
9376f7f
Compare
s1gr1d
approved these changes
Mar 25, 2025
AbhiPrasad
commented
Mar 25, 2025
AbhiPrasad
force-pushed
the
abhi-browser-logs-integration
branch
from
16cc20a to
c3605c4
Compare
AbhiPrasad
changed the title
AbhiPrasad
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15526