feat: Always truncate stored breadcrumb messages to 2kb #15819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
s1gr1d
reviewed
Mar 26, 2025
| timestamp: dateTimestampInSeconds(), | ||
| ...breadcrumb, | ||
| // Breadcrumb messages can theoretically be infinitely large and they're held in memory so we truncate them not to leak (too much) memory | ||
| message: breadcrumb.message ? truncate(breadcrumb.message, 2048) : breadcrumb.message, |
There was a problem hiding this comment.
Should we maybe provide an option for people to overwrite this value of 2kb?
Like maxMessageLength as option in the breadcrumb integration.
There was a problem hiding this comment.
We didn't have this option before and nobody asked for it so I would say no.
s1gr1d
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had this logic in the console instrumentation before but it probably makes sense to truncate all breadcrumbs to some degree for memory consumption reasons.
Acts as prework for #15818 because if we don't truncate error messages they will end up as very big strings in breadcrumbs.