ref(core): Avoid using SentryError for event processing control flow
#15823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
approved these changes
Mar 25, 2025
size-limit report 📦
|
AbhiPrasad
reviewed
Mar 25, 2025
packages/core/src/client.ts
Outdated
Comment on lines
98
to
104
| function isInternalError(error: unknown): error is InternalError { | ||
| return !!error && typeof error === 'object' && INTERNAL_ERROR_SYMBOL in error; | ||
| } | ||
|
|
||
| function isDoNotSendEventError(error: unknown): error is DoNotSendEventError { | ||
| return !!error && typeof error === 'object' && DO_NOT_SEND_EVENT_SYMBOL in error; | ||
| } |
There was a problem hiding this comment.
Although we want to differentiate them, we can use a single isX method for now given everything checks for both:
function isClientProcessingError(error: unknown): error is InternalError | DoNotSendEventError {
return !!error && typeof error === 'object' && (INTERNAL_ERROR_SYMBOL in error || DO_NOT_SEND_EVENT_SYMBOL in error);
}There was a problem hiding this comment.
actually it is not entirely the same, today we differentiate based on this if we do logger.log or logger.warn. Not sure how important that is to us though 🤔
There was a problem hiding this comment.
I guess we can keep them separate for now then.
mydea
force-pushed
the
fn/event-pipeline-sentry-error
branch
from
be83d3f to
19c86a4
Compare
mydea
force-pushed
the
fn/event-pipeline-sentry-error
branch
from
8fe61d1 to
08a50f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces our usage of
SentryErrorfor control flow in our event processing.Instead, we now throw either an
InternalErrororDoNotSendEventError(which are just POJOs with a symbol, without a stackframe). These two also allow us to differentiate between these two use cases, which so far have been kind of combined via the log level, but are really different things - one is "expected"/configured by a user, the other is unexpected and more of a warning.I also removed the handling for
SentryErrorfrom inbound filters, as this should then become unused.This also deprecates
SentryError, it is no longer used and we can eventually remove it.ref #15725 (comment)