feat(browser): Add outgoingRequest context to fetch errors#15850
Closed
feat(browser): Add outgoingRequest context to fetch errors#15850
outgoingRequest context to fetch errors#15850Conversation
For now, this only adds `method` and `url` fields.
mydea
force-pushed
the
fn/fetch-error-context
branch
from
53e3ea4 to
c4f3edf
Compare
Contributor
size-limit report 📦
|
Member
|
@mydea (once you're back) Is this still something we wanna pursue? PR LGTM in general but asking since it's been open for a while. |
Member
Author
|
hmm good question, maybe it's worth to double check if this still makes sens (I believe yes but to be sure)! |
Contributor
|
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you apply the label |
Contributor
|
Closing due to inactivity after stale warning. Comment or reopen when ready to continue, and use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For now, this only adds
methodandurlfields.Implements #15846 for
fetchonly. This is probably the most important, not sure if we also want to add this to XMLHttpRequest handling (it is possible there but a bit trickier, as we'd need to parse method/url out of the request etc)