fix(serverless-aws): Overwrite root span name with GraphQL if set #16010
+124
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
3 tasks
size-limit report 📦
|
Closed
3 tasks
mydea
reviewed
Apr 15, 2025
| }; | ||
|
|
||
| describe('GraphQL/Apollo Tests', () => { | ||
| test('should instrument GraphQL queries used from Apollo Server.', async () => { | ||
| const EXPECTED_TRANSACTION = { | ||
| transaction: 'Test Transaction', | ||
| transaction: 'Test Transaction (query)', |
There was a problem hiding this comment.
is this lacking a query name on purpose? 🤔
There was a problem hiding this comment.
The query in this test doesn't have a name:
await server.executeOperation({
query: '{hello}',
});Whereas, when it has one like this:
await apolloServer.executeOperation({
query: 'query GetHello {hello}',
});the transaction is named like this: Test Transaction (query GetHello)
mydea
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.