feat(browser): Add option to sample linked traces consistently #16037
+863
−29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements consistent sampling across traces as outlined in #15754. For a detailed write up see the issue.
Concrete changes:
sampleLinkedTracesConsistently
option (naming TBD but this is what I'm going with for now)beforeSampling
hook before sampling and creatingSentrySpan
's in the coreSDK (this hook is already called in Otel-based spans).beforeSampling
hook subscribers to alter spanattributes
andparentSampled
flagbeforeSampling
hook whensampleLinkedTracesConsistently
is enabled andlinkPreviousTrace
is not disabledparentSampled
flag based on the sampling decision, sample rate and sample rand of the previous tracetrace
envelope header. This is necessary to ensure correct span metrics extrapolation.