feat(nuxt): Log when adding HTML trace meta tags #16044
Open
+9
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Apr 14, 2025
packages/nuxt/src/runtime/utils.ts
Outdated
Comment on lines
42
to
45
| consoleSandbox(() => { | ||
| // eslint-disable-next-line no-console | ||
| console.log('[Sentry] Adding Sentry tracing meta tags to HTML page:', metaTags); | ||
| }); |
There was a problem hiding this comment.
m: can we use logger instead? then we don't need to worry about the sandbox
Lms24
approved these changes
Apr 14, 2025
packages/nuxt/src/runtime/utils.ts
Outdated
Comment on lines
41
to
43
| if (debug) { | ||
| logger.log('Adding Sentry tracing meta tags to HTML page:', metaTags); | ||
| } |
There was a problem hiding this comment.
l: I think I caused this confusion in our offline convo: We don't even need the debug flag check here because the logger won't emit anything unless people init the SDK with debug: true.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logging the tracing meta tags makes debugging things like this easier.