fix(deno): Handle reader.closed rejection from releaseLock() in streaming#20187
Open
andreiborza wants to merge 2 commits intodevelopfrom
Open
fix(deno): Handle reader.closed rejection from releaseLock() in streaming#20187andreiborza wants to merge 2 commits intodevelopfrom
reader.closed rejection from releaseLock() in streaming#20187andreiborza wants to merge 2 commits intodevelopfrom
Conversation
…treaming Replace `reader.closed.finally(() => onDone())` with `reader.closed.then(() => onDone(), () => onDone())` in `monitorStream`. Per the WHATWG Streams spec, `reader.releaseLock()` rejects `reader.closed` when the promise is still pending. `.finally()` propagates that rejection as an unhandled promise rejection, while `.then(f, f)` suppresses it by handling both the fulfilled and rejected cases. Closes: #20177
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Core
Bug Fixes 🐛
🤖 This preview updates automatically when you update the PR. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f21ef57. Configure here.
Contributor
size-limit report 📦
|
s1gr1d
approved these changes
Apr 10, 2026
Member
s1gr1d
left a comment
s1gr1d
left a comment
There was a problem hiding this comment.
Seems like a good approach - looks good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
reader.closed.finally(() => onDone())withreader.closed.then(() => onDone(), () => onDone())inmonitorStream.Per the WHATWG Streams spec,
reader.releaseLock()rejectsreader.closedwhen the promise is still pending..finally()propagates that rejection as an unhandled promise rejection, while.then(f, f)suppresses it by handling both the fulfilled and rejected cases.I was not able to reproduce the error directly on my deno version but this should prevent the issue.
Closes: #20177