Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the Mojos as thread-safe #128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nikita2206
Copy link
Contributor

📜 Description

Just marks the Mojos as thread-safe, this reduces the WARNING-level logging by Maven when running multi-threaded builds:

| [INFO] --------------------------------[ jar ]---------------------------------
| [WARNING] *****************************************************************
| [WARNING] * Your build is requesting parallel execution, but this         *
| [WARNING] * project contains the following plugin(s) that have goals not  *
| [WARNING] * marked as thread-safe to support parallel execution.          *
| [WARNING] * While this /may/ work fine, please look for plugin updates    *
| [WARNING] * and/or request plugins be made thread-safe.                   *
| [WARNING] * If reporting an issue, report it against the plugin in        *
| [WARNING] * question, not against Apache Maven.                           *
| [WARNING] *****************************************************************
| [WARNING] The following plugins are not marked as thread-safe in %module-name%:
| [WARNING]   io.sentry:sentry-maven-plugin:0.2.0
| [WARNING]
| [WARNING] Enable debug to see precisely which goals are not marked as thread-safe.
| [WARNING] *****************************************************************

💡 Motivation and Context

My understanding is that Sentry's plugin is in fact thread-safe, but was just never marked as such. Avoiding the warnings would help us, as we are paying attention to other warnings that are mainly coming from the Checkstyle plugin and having these mixed makes it harder to notice to those.

💚 How did you test it?

Did not test the change

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@lbloder
Copy link
Collaborator

lbloder commented Feb 25, 2025

Hi @nikita2206,
Thank you for providing this PR. We will take a look and come back to you as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants