fix(native): refrain from widening crashed_tid to uint64_t on macOS#1800
Draft
bitsandfoxes wants to merge 1 commit into
Draft
fix(native): refrain from widening crashed_tid to uint64_t on macOS#1800bitsandfoxes wants to merge 1 commit into
crashed_tid to uint64_t on macOS#1800bitsandfoxes wants to merge 1 commit into
Conversation
bitsandfoxes
force-pushed
the
fix/crashed-tid-64
branch
from
4b4f2a6 to
1b68c82
Compare
bitsandfoxes
changed the title
crashed_tid as uint64_t instead of pid_tcrashed_tid to uint64_t on macOS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As far as I can tell this came through this being implemented for Linux first where the thread ID genuinely is a
pid_t(32-bit). Windows has this as aDWORDwhich is 32-bit too.Later on macOS got retrofit, and
thread_identifier_info.thread_idreturning a 64-bit caused the squeeze via(pid_t)target_tid.But since the minidump format in the end has it as 32-bit anyway, it doesn't make sense to neither widen
crashed_tidneither in the context nor in the comparison.#skip-changelog