feat: add attachment support #1925
Conversation
| switch ($event->getType()) { | ||
| case EventType::event(): | ||
| $items[] = EventItem::toEnvelopeItem($event); | ||
| $items[] = AttachmentItem::toEnvelopeItem($event); |
There was a problem hiding this comment.
For clarity I think I would go for this (also in the transaction) instead and move the loop here. Yes it's a little more duplicated code but I think the clarity is a little better to also keep all the toEnvelopeItem methods returning a single item instead of multiple or none.
| $items[] = AttachmentItem::toEnvelopeItem($event); | |
| foreach ($event->getAttachments() as $attachment) { | |
| $items[] = AttachmentItem::toEnvelopeItem($attachment); | |
| } |
There was a problem hiding this comment.
True, very good point!
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| public function getData(): ?string | ||
| { | ||
| return @file_get_contents($this->path) ?: null; | ||
| } |
There was a problem hiding this comment.
Bug: Null Handling Bug in File Operations
The ?: null operator in getSize() and getData() incorrectly handles empty files. It converts filesize()'s 0 and file_get_contents()'s empty string '' into null. This causes empty files to be treated as unreadable, conflicting with tests expecting 0 for size and '' for data.
| } | ||
|
|
||
| return implode("\n", $result); | ||
| } |
There was a problem hiding this comment.
Bug: Null Attachments Cause Malformed Envelope Data
The toEnvelopeItem method includes null results from toAttachmentItem when attachment data is missing. These null values are then converted to empty strings by implode("\n", $result), creating extra newlines and malformed envelope data that can cause parsing issues.
2 participants
Introducing attachment support for PHP!
Attachments can be set on Scopes and will be added to Errors and Transaction events when sending them to sentry.
The PR currently does not enforce limits and reads the entire attachment content in memory before sending it. There is room for improvement such as respecting attachment limits as well as streaming the envelope to reduce the memory impact.