feat(eap): add BinaryFormula to AggregationComparisonFilter#133
Merged
onewland merged 4 commits intoAug 1, 2025
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
kylemumma
reviewed
Jul 31, 2025
kylemumma
approved these changes
Jul 31, 2025
onkar
reviewed
Aug 1, 2025
…-aggregation-comparison-filter
onewland
added a commit
to getsentry/snuba
that referenced
this pull request
Aug 6, 2025
Allow for BinaryFormula style filtering based on the results of aggregations. This doesn't buy us much in terms of performance (all the aggregations still need to be computed) but it's convenient for callers. Requires getsentry/sentry-protos#133, tested with: ``` $ pip install -e ../sentry-protos/py --config-settings editable_mode=strict ``` The test failing in CI is passing [[internal ticket]](https://linear.app/getsentry/issue/EAP-74/allow-aggregationcomparisonfilter-to-support-binaryformula)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reusing Column.BinaryFormula here because creating a common BinaryFormula was putting me into dependency hell. But open to other approaches
https://linear.app/getsentry/issue/EAP-74/allow-aggregationcomparisonfilter-to-support-binaryformula