feat(cross-item-queries): Add trace item filters with type in trace item table and time series endpoints#136
Merged
Merged
Conversation
|
The latest Buf updates on your PR. Results from workflow ci / buf-checks (pull_request).
|
phacops
approved these changes
Aug 5, 2025
volokluev
reviewed
Aug 5, 2025
| // one for prod, one for dev etc | ||
| repeated AttributeKey group_by = 5; | ||
|
|
||
| repeated TraceItemFilterWithType trace_filters = 7; |
Member
There was a problem hiding this comment.
I'm confused how this is supposed to work. can you include an example query for how this endpoint is supposed to function now that there are two types of filters here?
Contributor
Author
There was a problem hiding this comment.
it works exactly the same way GetTraces works, but I can add a comment
Member
There was a problem hiding this comment.
I would like to see an example (aka a test) such that as a product developer I can see what the intended usage is. A few things I'm confused about:
- will
trace_filtersreplacefilter? seems liketrace_filtersare a superset offilterfunctionality - as a user of this interface I see "enables cross-item queries` that doesn't really mean anything to me, what does it mean for me the user?
Contributor
Author
There was a problem hiding this comment.
I have added a test.
trace_filterswill not replacefilteras they are responsible for different filters. First,trace_filterswill filter out traces by only getting traces that contain items matching the conditions. Then, the regular trace item table or timeseries query will run with the additional condition that only those traces returned by the first query will be considered. In other words,trace_filtersare applied on a trace level to filter out traces andfilteris applied on the actual items in the traces.- Good point, I have updated the description to explain what the functionality actually is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding trace item filters with type for cross item query support