Skip to content

feat(explore): Add optional index field to AttributeKey for array element access #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manessaraj wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(explore): Add optional index field to AttributeKey for array element access #250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
df4b258
feat(explore): Add optional index field to AttributeKey for array ele…
manessaraj May 8, 2026
9c27a3c
chore: Regenerate Rust bindings
getsantry[bot] May 8, 2026
fbd49c1
Remove the negative indexing possibility
manessaraj May 8, 2026
e1a8c33
chore: Regenerate Rust bindings
getsantry[bot] May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions proto/sentry_protos/snuba/v1/trace_item_attribute.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ message AttributeKey {
// `sentry.` to allow users to send attributes of the same name.
// Exampe: `sentry.duration`, `sentry.span_id` etc
string name = 2;

// Optional indexed access into an array-typed attribute (only meaningful when type == TYPE_ARRAY).
optional uint32 index = 3;
Comment thread
manessaraj marked this conversation as resolved.
}

// this allow us to select single key such as span.attr1
Expand Down
3 changes: 3 additions & 0 deletions rust/src/sentry_protos.snuba.v1.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ pub struct AttributeKey {
/// Exampe: `sentry.duration`, `sentry.span_id` etc
#[prost(string, tag = "2")]
pub name: ::prost::alloc::string::String,
/// Optional indexed access into an array-typed attribute (only meaningful when type == TYPE_ARRAY).
#[prost(uint32, optional, tag = "3")]
pub index: ::core::option::Option<u32>,
}
/// Nested message and enum types in `AttributeKey`.
pub mod attribute_key {
Expand Down
Loading