-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref(tracing): Move TRANSACTION_SOURCE_*
constants to Enum
#3889
base: master
Are you sure you want to change the base?
ref(tracing): Move TRANSACTION_SOURCE_*
constants to Enum
#3889
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3889 +/- ##
==========================================
- Coverage 80.16% 80.15% -0.02%
==========================================
Files 139 139
Lines 15394 15396 +2
Branches 2596 2597 +1
==========================================
Hits 12341 12341
- Misses 2207 2215 +8
+ Partials 846 840 -6
|
f4bb234
to
ef97faa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thanks for the cleanup
This breaks a lot of tests, because the full enum ends up in the envelope that is sent to Sentry and not the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the tests, by making sure the .value
of the enum (the string) ends up in the envelop json payload that is sent to Sentry.
Head branch was pushed to by a user without write access
b016caf
to
79f20d7
Compare
Thank you @antonpirker! Now linter and tests passing! 💪 |
79f20d7
to
e135bbc
Compare
e135bbc
to
6609d89
Compare
Fixes GH-2696