-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logs): Make the logging
integration send Sentry logs
#4143
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #4143 +/- ##
==========================================
- Coverage 79.57% 79.57% -0.01%
==========================================
Files 141 141
Lines 15738 15790 +52
Branches 2675 2696 +21
==========================================
+ Hits 12524 12565 +41
+ Misses 2369 2368 -1
- Partials 845 857 +12
|
logging
integration send Sentry logs
045fa2a
to
42c3835
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good. I have some questions
88f390c
to
592ef9d
Compare
9e3db38
to
326d88a
Compare
326d88a
to
6763af2
Compare
6763af2
to
0367592
Compare
9e0a0f4
to
3db6a16
Compare
140d8cc
to
44fcd1f
Compare
@colin-sentry I have moved the new parameter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good now. 🔥
We have integrations that make the python logger create breadcrumbs and issues. This adds a third handler which creates Sentry logs on
logger.log
statements.Enable the logger with:
Refs #4150