Skip to content

ref: Remove _capture_experimental_log scope parameter #4424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: szokeasaurusrex/logs-user-attributes
Choose a base branch
from

Conversation

szokeasaurusrex
Copy link
Member

We are always just using the current scope anyway; it is less confusing if we eliminate the parameter

Stacked on:

@szokeasaurusrex szokeasaurusrex requested a review from a team as a code owner May 28, 2025 16:25
Copy link

codecov bot commented May 28, 2025

❌ 47 Tests Failed:

Tests completed Failed Passed Skipped
24187 47 24140 5824
View the top 3 failed test(s) by shortest run time
tests.integrations.asyncio.test_asyncio::test_exception
Stack Traces | 0.001s run time
async def functions are not natively supported.
You need to install a suitable plugin for your async framework, for example:
  - anyio
  - pytest-asyncio
  - pytest-tornasync
  - pytest-trio
  - pytest-twisted
tests.test_crons::test_contextmanager_error_async
Stack Traces | 0.001s run time
async def functions are not natively supported.
You need to install a suitable plugin for your async framework, for example:
  - anyio
  - pytest-asyncio
  - pytest-tornasync
  - pytest-trio
  - pytest-twisted
tests.test_crons::test_decorator_async
Stack Traces | 0.001s run time
async def functions are not natively supported.
You need to install a suitable plugin for your async framework, for example:
  - anyio
  - pytest-asyncio
  - pytest-tornasync
  - pytest-trio
  - pytest-twisted

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-scopes branch from 4280451 to 642e3db Compare June 3, 2025 12:22
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-user-attributes branch 2 times, most recently from a903eb6 to 285abb0 Compare June 3, 2025 12:25
We are always just using the current scope anyway; it is less confusing if we eliminate the parameter
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/logs-scopes branch from 642e3db to b553ca0 Compare June 3, 2025 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant