-
Notifications
You must be signed in to change notification settings - Fork 549
fix(integrations/ray): Correctly pass keyword arguments to ray.remote function #4430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
… function Monkey-patched implementation was passing the provided keyword arguments incorrectly due to a typo - "*kwargs" was used instead of "**kwargs" twice. Fixed integration started hitting an assert in the Ray codebase that requires for users to use "@ray.remote" decorator either with no arguments and no parentheses, or with some of the arguments provided. An additional wrapper function was added to support both scenarios.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4430 +/- ##
==========================================
+ Coverage 80.67% 80.68% +0.01%
==========================================
Files 142 142
Lines 15982 15988 +6
Branches 2729 2731 +2
==========================================
+ Hits 12893 12900 +7
Misses 2232 2232
+ Partials 857 856 -1
|
@sentrivana thank you for merging the I fixed the mypy errors (and added a missing |
Hey @svartalf, thanks for the PR! We still have to properly review this but until then could I ask you to please:
Re: the codecov warning, we can reevaluate if we need more test coverage afterwards too, but I think this should already be properly covered, will check when reviewing. |
Done! It looks like adding the
I removed this
Anyway, I guess, as long as mypy is happy… :) |
Monkey-patched implementation was passing the provided keyword arguments incorrectly due to a typo - "*kwargs" was used instead of "**kwargs" twice.
Fixed integration started hitting an assert in the Ray codebase that requires for users to use "@ray.remote" decorator either with no arguments and no parentheses, or with some of the arguments provided.
An additional wrapper function was added to support both scenarios.
Thank you for contributing to
sentry-python
! Please add tests to validate your changes, and lint your code usingtox -e linters
.Running the test suite on your PR might require maintainer approval.