-
-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): Implements Report a Bug button #4378
base: feedback-ui-2
Are you sure you want to change the base?
feat(feedback): Implements Report a Bug button #4378
Conversation
Co-authored-by: Krystof Woldrich <[email protected]>
…ct-Button # Conflicts: # CHANGELOG.md
…ct-Button # Conflicts: # CHANGELOG.md
|
…ct-Button # Conflicts: # CHANGELOG.md
* The props for the feedback button | ||
*/ | ||
export interface FeedbackButtonProps extends FeedbackButtonTextConfiguration { | ||
showFeedbackButton?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would replace the showFeedbackButton
option with static API Sentry.showFeedbackButton()
and Sentry.hideFeedbackButton()
to allow for more dynamic scenarios, like showing the button when an error happens or when shake gesture is detected.
The styles, I think, make sense to set in the integration option as it is.
The hide, I think, is important in this case to allow for hiding the button after the feedback is submitted, for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea Krystof 👍
Updated with 06adadd
Let's also add a dummy button integration to track the usage of the button.
(In the long term, we should start using the features field. I'll create an issue for that.) |
Co-authored-by: Krystof Woldrich <[email protected]>
…ct-Button # Conflicts: # CHANGELOG.md
Thank you for reviewing and your feedback @krystofwoldrich 🙇
Good catch 👍 Should be fixed after 04f1a8d
Good point! Added with 7473c58
Good catch 👍 Added the border with 24b3df0 |
…ct-Button # Conflicts: # CHANGELOG.md
📢 Type of change
📜 Description
Implements feedback button that launches the feedback widget using the auto-injected feedback widget
The button is shown with
Sentry.showFeedbackButton()
and hidden withSentry.hideFeedbackButton()
provided that the app is wrapped (Sentry.wrap(RootComponent)
). The button can be styled like:💡 Motivation and Context
Part of #4302
💚 How did you test it?
Manual testing with the sample app
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps