Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sample): Update Expo and related dependencies to the doctor recommended versions #4701

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Mar 27, 2025

#skip-changelog

Updates the Expo Sample dependencies to the Expo Doctor-recommended versions.

Before:
Screenshot 2025-03-27 at 12 35 18

After:
Screenshot 2025-03-27 at 12 31 39

@krystofwoldrich krystofwoldrich requested review from Copilot and removed request for antonis and lucas-zimerman March 27, 2025 11:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (2)
  • samples/expo/app.json: Language not supported
  • samples/expo/package.json: Language not supported

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 420.86 ms 450.09 ms 29.23 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
e73d82f 475.82 ms 506.55 ms 30.73 ms
7fd512a 442.18 ms 437.57 ms -4.61 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
5571a20 410.55 ms 441.06 ms 30.51 ms
9385d74 432.71 ms 423.56 ms -9.15 ms
7e87527 425.56 ms 407.64 ms -17.93 ms
0677344 327.74 ms 337.14 ms 9.40 ms
2534337 394.15 ms 415.12 ms 20.97 ms
8900e1a+dirty 430.68 ms 456.13 ms 25.44 ms
13f280b 486.16 ms 472.45 ms -13.71 ms

App size

Revision Plain With Sentry Diff
e73d82f 17.73 MiB 20.07 MiB 2.33 MiB
7fd512a 17.74 MiB 20.08 MiB 2.35 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
5571a20 17.73 MiB 19.93 MiB 2.19 MiB
9385d74 17.74 MiB 20.09 MiB 2.35 MiB
7e87527 17.75 MiB 20.11 MiB 2.37 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
8900e1a+dirty 17.73 MiB 19.75 MiB 2.01 MiB
13f280b 17.74 MiB 20.08 MiB 2.34 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.18 ms 1220.65 ms 2.47 ms
Size 2.63 MiB 3.76 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
484813b+dirty 1222.45 ms 1220.79 ms -1.66 ms
60d7316+dirty 1219.13 ms 1221.74 ms 2.61 ms
22e31b6+dirty 1253.62 ms 1265.96 ms 12.34 ms
e22745e+dirty 1222.73 ms 1224.98 ms 2.25 ms
e1ea4a8+dirty 1233.49 ms 1237.71 ms 4.22 ms
0d3e677+dirty 1214.39 ms 1225.70 ms 11.31 ms
c639edf+dirty 1236.18 ms 1235.04 ms -1.14 ms
7d161c0+dirty 1215.20 ms 1218.64 ms 3.43 ms
abb7058+dirty 1255.42 ms 1268.86 ms 13.44 ms
22bcd92+dirty 1230.50 ms 1233.39 ms 2.89 ms

App size

Revision Plain With Sentry Diff
484813b+dirty 2.36 MiB 3.08 MiB 734.18 KiB
60d7316+dirty 2.63 MiB 3.74 MiB 1.11 MiB
22e31b6+dirty 2.36 MiB 2.87 MiB 520.67 KiB
e22745e+dirty 2.36 MiB 3.10 MiB 752.32 KiB
e1ea4a8+dirty 2.36 MiB 3.10 MiB 752.31 KiB
0d3e677+dirty 2.36 MiB 3.10 MiB 753.12 KiB
c639edf+dirty 2.36 MiB 3.08 MiB 736.63 KiB
7d161c0+dirty 2.63 MiB 3.75 MiB 1.12 MiB
abb7058+dirty 2.36 MiB 2.87 MiB 520.42 KiB
22bcd92+dirty 2.63 MiB 3.76 MiB 1.13 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1215.88 ms 1229.51 ms 13.63 ms
Size 3.19 MiB 4.33 MiB 1.14 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
484813b+dirty 1225.07 ms 1221.00 ms -4.07 ms
60d7316+dirty 1224.33 ms 1231.29 ms 6.96 ms
22e31b6+dirty 1276.55 ms 1278.12 ms 1.57 ms
e22745e+dirty 1246.02 ms 1233.60 ms -12.42 ms
e1ea4a8+dirty 1228.98 ms 1222.80 ms -6.18 ms
0d3e677+dirty 1239.02 ms 1241.22 ms 2.20 ms
c639edf+dirty 1223.63 ms 1227.98 ms 4.35 ms
7d161c0+dirty 1239.57 ms 1250.46 ms 10.89 ms
abb7058+dirty 1260.28 ms 1266.56 ms 6.28 ms
22bcd92+dirty 1219.98 ms 1225.23 ms 5.25 ms

App size

Revision Plain With Sentry Diff
484813b+dirty 2.92 MiB 3.64 MiB 740.56 KiB
60d7316+dirty 3.19 MiB 4.30 MiB 1.12 MiB
22e31b6+dirty 2.92 MiB 3.43 MiB 524.74 KiB
e22745e+dirty 2.92 MiB 3.66 MiB 756.73 KiB
e1ea4a8+dirty 2.92 MiB 3.66 MiB 756.65 KiB
0d3e677+dirty 2.92 MiB 3.66 MiB 758.42 KiB
c639edf+dirty 2.92 MiB 3.64 MiB 742.55 KiB
7d161c0+dirty 3.19 MiB 4.32 MiB 1.13 MiB
abb7058+dirty 2.92 MiB 3.43 MiB 524.53 KiB
22bcd92+dirty 3.19 MiB 4.33 MiB 1.14 MiB

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants