Skip to content

chore(deps-v7): update Cocoa SDK to v8.51.0 #4843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: v7
Choose a base branch
from

Conversation

lucas-zimerman
Copy link
Collaborator

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

@lucas-zimerman lucas-zimerman mentioned this pull request May 20, 2025
18 tasks
@lucas-zimerman lucas-zimerman changed the title Bump cocoa sdk to 8.51.0 Bump cocoa SDK to 8.51.0 May 20, 2025
@lucas-zimerman lucas-zimerman marked this pull request as ready for review May 20, 2025 14:20
Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for bumping Cocoa in v7 @lucas-zimerman 🙇
I think there is an issue with the latest cocoa release causing our CI checks to fail. I'm still investigating why this happens but my understanding is that the changes in getsentry/sentry-cocoa#5018 may delay the upload of the replays causing the api request to fail with 404.

Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 421.74 ms 415.55 ms -6.19 ms
Size 17.75 MiB 19.54 MiB 1.80 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
8a54dff 482.57 ms 467.16 ms -15.41 ms
9fbcfaf 420.06 ms 435.31 ms 15.25 ms
9da5c4e 478.08 ms 467.46 ms -10.63 ms

App size

Revision Plain With Sentry Diff
8a54dff 17.75 MiB 19.54 MiB 1.80 MiB
9fbcfaf 17.75 MiB 19.54 MiB 1.79 MiB
9da5c4e 17.75 MiB 20.16 MiB 2.41 MiB

@krystofwoldrich krystofwoldrich changed the title Bump cocoa SDK to 8.51.0 chore(deps-v7): update Cocoa SDK to v8.51.0 May 20, 2025
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 398.45 ms 393.91 ms -4.53 ms
Size 7.15 MiB 8.30 MiB 1.15 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
8a54dff+dirty 393.65 ms 392.32 ms -1.33 ms
9fbcfaf+dirty 417.92 ms 431.81 ms 13.90 ms
9da5c4e+dirty 399.70 ms 407.34 ms 7.64 ms

App size

Revision Plain With Sentry Diff
8a54dff+dirty 7.15 MiB 8.30 MiB 1.15 MiB
9fbcfaf+dirty 7.15 MiB 8.29 MiB 1.14 MiB
9da5c4e+dirty 7.15 MiB 8.42 MiB 1.27 MiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1219.84 ms 1215.35 ms -4.49 ms
Size 3.19 MiB 4.32 MiB 1.13 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1215.22 ms 1222.26 ms 7.04 ms
9da5c4e+dirty 1215.41 ms 1226.38 ms 10.97 ms
8a54dff+dirty 1244.29 ms 1254.71 ms 10.43 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 3.19 MiB 4.34 MiB 1.15 MiB
9da5c4e+dirty 3.19 MiB 4.33 MiB 1.14 MiB
8a54dff+dirty 3.19 MiB 4.35 MiB 1.17 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1230.63 ms 1228.92 ms -1.71 ms
Size 2.63 MiB 3.75 MiB 1.12 MiB

Baseline results on branch: v7

Startup times

Revision Plain With Sentry Diff
9fbcfaf+dirty 1216.66 ms 1212.06 ms -4.60 ms
9da5c4e+dirty 1231.84 ms 1235.49 ms 3.65 ms
8a54dff+dirty 1226.17 ms 1227.79 ms 1.63 ms

App size

Revision Plain With Sentry Diff
9fbcfaf+dirty 2.63 MiB 3.77 MiB 1.14 MiB
9da5c4e+dirty 2.63 MiB 3.76 MiB 1.13 MiB
8a54dff+dirty 2.63 MiB 3.79 MiB 1.16 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants