Skip to content

Automatically bump v7 dependencies #4845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented May 20, 2025

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This is a small change on update-devs.yml to allow updates automatically on v7 branch

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@lucas-zimerman lucas-zimerman marked this pull request as ready for review May 20, 2025 14:27
Copy link
Member

@krystofwoldrich krystofwoldrich May 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be nice, for cases like this when we develop a new major version of the SDK, but it won't work, since the updater action automatically detects the main branch.

https://github.com/getsentry/github-workflows/blob/cd1c852719aaf272f2730a2df1146dba80412ee3/.github/workflows/updater.yml#L130

We would have to allow to specify the base branch or allow mode where it takes as a base the current local HEAD and also make sure the PRs are not overwritten.

Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 397.91 ms 404.48 ms 6.57 ms
Size 7.15 MiB 8.42 MiB 1.26 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b95b8af+dirty 392.94 ms 428.00 ms 35.06 ms
7e87527+dirty 406.35 ms 465.24 ms 58.90 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
75774ea+dirty 426.80 ms 455.43 ms 28.62 ms
c81e67f+dirty 355.71 ms 364.96 ms 9.24 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
ea85ff8+dirty 409.16 ms 402.47 ms -6.70 ms
a0b0298+dirty 424.06 ms 423.76 ms -0.30 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
77680ec+dirty 393.50 ms 426.68 ms 33.18 ms

App size

Revision Plain With Sentry Diff
b95b8af+dirty 7.15 MiB 8.38 MiB 1.23 MiB
7e87527+dirty 7.15 MiB 8.38 MiB 1.23 MiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
75774ea+dirty 7.15 MiB 8.36 MiB 1.21 MiB
c81e67f+dirty 7.15 MiB 8.39 MiB 1.23 MiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
ea85ff8+dirty 7.15 MiB 8.39 MiB 1.23 MiB
a0b0298+dirty 7.15 MiB 8.39 MiB 1.23 MiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
77680ec+dirty 7.15 MiB 8.35 MiB 1.20 MiB

Copy link
Contributor

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1217.16 ms 1230.10 ms 12.94 ms
Size 2.63 MiB 3.82 MiB 1.19 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5852d77+dirty 1210.16 ms 1222.60 ms 12.44 ms
5571a20+dirty 1203.57 ms 1204.57 ms 1.00 ms
432a4cb+dirty 1212.82 ms 1215.76 ms 2.94 ms
80f7e8a+dirty 1215.77 ms 1217.73 ms 1.96 ms
c71ea72+dirty 1225.76 ms 1229.51 ms 3.76 ms
afe5fcb+dirty 1220.94 ms 1214.73 ms -6.21 ms
e2b64fe+dirty 1232.22 ms 1255.20 ms 22.98 ms
e652a2e+dirty 1221.86 ms 1219.79 ms -2.07 ms
d997097+dirty 1231.90 ms 1236.80 ms 4.90 ms
8900e1a+dirty 1210.27 ms 1218.66 ms 8.39 ms

App size

Revision Plain With Sentry Diff
5852d77+dirty 2.63 MiB 3.74 MiB 1.11 MiB
5571a20+dirty 2.36 MiB 2.92 MiB 569.93 KiB
432a4cb+dirty 2.63 MiB 3.78 MiB 1.15 MiB
80f7e8a+dirty 2.63 MiB 3.80 MiB 1.17 MiB
c71ea72+dirty 2.63 MiB 3.68 MiB 1.05 MiB
afe5fcb+dirty 2.63 MiB 3.70 MiB 1.06 MiB
e2b64fe+dirty 2.36 MiB 2.85 MiB 495.80 KiB
e652a2e+dirty 2.63 MiB 3.74 MiB 1.11 MiB
d997097+dirty 2.63 MiB 3.70 MiB 1.06 MiB
8900e1a+dirty 2.36 MiB 2.83 MiB 479.25 KiB

Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.41 ms 1233.78 ms -2.63 ms
Size 3.19 MiB 4.39 MiB 1.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5852d77+dirty 1226.88 ms 1236.38 ms 9.50 ms
5571a20+dirty 1228.09 ms 1233.45 ms 5.36 ms
432a4cb+dirty 1218.94 ms 1215.48 ms -3.46 ms
80f7e8a+dirty 1216.40 ms 1215.44 ms -0.97 ms
c71ea72+dirty 1221.39 ms 1231.77 ms 10.38 ms
afe5fcb+dirty 1223.53 ms 1223.90 ms 0.37 ms
e2b64fe+dirty 1285.78 ms 1297.56 ms 11.78 ms
e652a2e+dirty 1224.76 ms 1218.86 ms -5.90 ms
d997097+dirty 1223.29 ms 1229.76 ms 6.46 ms
8900e1a+dirty 1268.36 ms 1273.04 ms 4.68 ms

App size

Revision Plain With Sentry Diff
5852d77+dirty 3.19 MiB 4.30 MiB 1.12 MiB
5571a20+dirty 2.92 MiB 3.48 MiB 575.54 KiB
432a4cb+dirty 3.19 MiB 4.35 MiB 1.16 MiB
80f7e8a+dirty 3.19 MiB 4.37 MiB 1.18 MiB
c71ea72+dirty 3.19 MiB 4.25 MiB 1.06 MiB
afe5fcb+dirty 3.19 MiB 4.26 MiB 1.08 MiB
e2b64fe+dirty 2.92 MiB 3.41 MiB 499.97 KiB
e652a2e+dirty 3.19 MiB 4.31 MiB 1.12 MiB
d997097+dirty 3.19 MiB 4.26 MiB 1.08 MiB
8900e1a+dirty 2.92 MiB 3.39 MiB 485.96 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants