Add child_spans for Sidekiq Queue instrumentation #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikspang
force-pushed
the
feature/sidekiq-queues-childspan
branch
2 times, most recently
from
cd35fcf
to
787436b
Compare
nateberkopec
suggested changes
Sep 16, 2024
frederikspang
force-pushed
the
feature/sidekiq-queues-childspan
branch
2 times, most recently
from
65a5c73
to
ac46c1b
Compare
frederikspang
force-pushed
the
feature/sidekiq-queues-childspan
branch
from
ac46c1b
to
4e505f6
Compare
nateberkopec
approved these changes
Sep 23, 2024
|
Oh wow, exactly what I was looking for 😅 🙌 can we somehow help to get this shipped? 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #2322 for Sidekiq.
Description
Adds support for Sentry Queues page (With predefined span
opnames)https://docs.sentry.io/platforms/ruby/guides/sidekiq/tracing/instrumentation/custom-instrumentation/queues-module/