fix(types): Serialize attachment headers as JSON#1109
Merged
szokeasaurusrex merged 1 commit intomasterfrom May 6, 2026
Merged
Conversation
Use serde_json to write attachment item headers instead of formatting the JSON string manually. This keeps string fields encoded consistently with the rest of envelope serialization.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/attachment-header-serialization
branch
from
7bb5337 to
4aa5c1a
Compare
szokeasaurusrex
deleted the
szokeasaurusrex/attachment-header-serialization
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use serde_json to write attachment item headers instead of formatting the JSON string manually. This keeps string fields encoded consistently with the rest of envelope serialization.