Skip to content

Conversation

manifest
Copy link
Contributor

@manifest manifest commented Aug 5, 2024

The PR for the issue.

Description for the `flush` function of the `Transport` trait states that
"If the queue was successfully drained, the return value should be `true`.",
but implementation of the trait on `tokio_thread::TransportThread`
do the oposite. The same error for `thread::TransportThread`.
Copy link
Member

@Swatinem Swatinem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@viglia viglia merged commit 16baf61 into getsentry:master Oct 3, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants