Skip to content

fix: Implicitly marking parameter as nullable is deprecated #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

NikoGrano
Copy link
Contributor

Fixed PHP 8.4: Implicitly nullable parameter declarations deprecated.

Ref

@cleptric cleptric merged commit 7820516 into getsentry:master Nov 14, 2024
33 checks passed
@ruudk
Copy link
Contributor

ruudk commented Nov 19, 2024

Thanks for this. Could this please be tagged? @Jean85

@Jean85
Copy link
Contributor

Jean85 commented Nov 19, 2024

The release schedule is up to @cleptric

@cleptric
Copy link
Member

This PR didn't fix all incompatibilities, a followup was created as #893. I'm currently looking into the last remaining CI failure, we'll get a release out before Thursday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants