-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Propagate traceId
to the Android SDK
#1997
base: main
Are you sure you want to change the base?
Conversation
traceId
on AndroidtraceId
to the Android SDK
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Propagate `traceId` to the Android SDK ([#1997](https://github.com/getsentry/sentry-unity/pull/1997)) If none of the above apply, you can opt out of this check by adding |
{ | ||
options.DiagnosticLogger?.LogInfo("Setting Trace ID"); | ||
|
||
var traceId = SentrySdk.GetTraceHeader()?.TraceId; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we get a hook from the .NET SDK so when a new trace-id is set there, we are able to pass that down to native.
Similar to ScopeObserver
. Perhaps it should live there actually.
Because we don't want a single trace id for the lifetime of the game ideally. It should recycle "at some point". Perhaps when a scene loads? We could also reset if session ends/restarts.
Proof of concept. Java errors share the same
trace ID
as the events coming from the C# layer. Native errors lack the trace context.