-
-
Notifications
You must be signed in to change notification settings - Fork 75
Fixes #1093 #1094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1093 #1094
Conversation
Co-authored-by: dgriesser <[email protected]>
…accidental test spam (#1093) This removes the example capture call entirely to prevent users from unintentionally sending many messages and burning quota.
Cursor Agent can help with this pull request. Just |
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Fixes #1093 ([#1094](https://github.com/getsentry/sentry-wizard/pull/1094)) If none of the above apply, you can opt out of this check by adding |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1094 +/- ##
=======================================
Coverage 32.12% 32.12%
=======================================
Files 133 133
Lines 15695 15695
Branches 1100 1100
=======================================
Hits 5042 5042
Misses 10636 10636
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adjust Swift/ObjC expected snippets and remove leftover merge markers in tests.
// Remove the next line after confirming that your Sentry integration is working. | ||
SentrySDK.capture(message: "This app uses Sentry! :)")\n`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@HazAT, I though we want to comment out capture message and not remove it
snippet += ` | ||
} | ||
// Remove the next line after confirming that your Sentry integration is working. | ||
SentrySDK.capture(message: "This app uses Sentry! :)")\n`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decided to do #1102 instead. |
Remove
captureMessage
from Apple templates to prevent accidental event spam and quota burn.Fixes #1093