Skip to content

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Oct 13, 2025

Remove default options.debug from Apple SDK snippets as per issue #1092.


Open in Cursor Open in Web

Removes default `options.debug` from Swift and Objective-C snippets per #1092 to avoid enabling debug by default.
Copy link

cursor bot commented Oct 13, 2025

Cursor Agent can help with this pull request. Just @cursor in comments and I'll start working on changes in this branch.
Learn more about Cursor Agents

Adjusts unit tests to reflect removal of default debug settings in Swift and Objective-C snippets per #1092.
@HazAT HazAT marked this pull request as ready for review October 13, 2025 18:40
Copy link

codecov bot commented Oct 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.12%. Comparing base (f5eff31) to head (dd04017).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1096   +/-   ##
=======================================
  Coverage   32.12%   32.12%           
=======================================
  Files         133      133           
  Lines       15695    15695           
  Branches     1100     1100           
=======================================
  Hits         5042     5042           
  Misses      10636    10636           
  Partials       17       17           
Flag Coverage Δ
unit-tests 32.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@HazAT HazAT changed the title Implement apple snippet changes in PR Fixes #1092 Oct 13, 2025
@philipphofmann
Copy link
Member

@cursor please add the changelog entry as pointed out in #1096 (comment)

Copy link

cursor bot commented Oct 14, 2025

❌ Unable to add follow-up after multiple attempts. The agent may be experiencing issues.

Please try again later or check the agent status.


Open in Cursor Open in Web

Learn more about Cursor Agents

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, after cursors adds the changelog

@Lms24 Lms24 changed the title Fixes #1092 fix(apple): Remove options.debug: true from SDK init snippet Oct 14, 2025
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So much for AI replacing us :D

@Lms24 Lms24 merged commit 4ab7f7f into master Oct 14, 2025
42 checks passed
@Lms24 Lms24 deleted the cursor/implement-apple-snippet-changes-in-pr-729a branch October 14, 2025 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants