-
-
Notifications
You must be signed in to change notification settings - Fork 75
fix(apple): Remove options.debug: true
from SDK init snippet
#1096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(apple): Remove options.debug: true
from SDK init snippet
#1096
Conversation
Removes default `options.debug` from Swift and Objective-C snippets per #1092 to avoid enabling debug by default.
Cursor Agent can help with this pull request. Just |
Adjusts unit tests to reflect removal of default debug settings in Swift and Objective-C snippets per #1092.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1096 +/- ##
=======================================
Coverage 32.12% 32.12%
=======================================
Files 133 133
Lines 15695 15695
Branches 1100 1100
=======================================
Hits 5042 5042
Misses 10636 10636
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@cursor please add the changelog entry as pointed out in #1096 (comment) |
❌ Unable to add follow-up after multiple attempts. The agent may be experiencing issues. Please try again later or check the agent status. Learn more about Cursor Agents |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, after cursors adds the changelog
options.debug: true
from SDK init snippet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much for AI replacing us :D
Remove default
options.debug
from Apple SDK snippets as per issue #1092.