fix(seer): Gracefully filter non-Sentry GitHub check_run webhooks#114909
Draft
sentry[bot] wants to merge 1 commit intomasterfrom
Draft
fix(seer): Gracefully filter non-Sentry GitHub check_run webhooks#114909sentry[bot] wants to merge 1 commit intomasterfrom
sentry[bot] wants to merge 1 commit intomasterfrom
Conversation
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where
ValueError: invalid literal for int() with base 10: ''was being raised and logged when processing GitHubcheck_runwebhooks from third-party CI tools (e.g., Codecov).Root Cause:
Sentry's
_validate_github_check_run_eventfunction attempted to convertcheck_run.external_idto an integer usingint(). While Sentry's own check runs populate this field with a numeric Seer run ID, third-party CI tools often send an empty string''forexternal_id(as it's an optional field for them). Callingint('')results in aValueError.Although this error was caught and prevented a 500 response to GitHub, it still generated Sentry issues, creating unnecessary noise.
Solution:
Instead of relying on an exception, this change implements an explicit early filter for
check_runwebhooks that do not originate from Sentry's Seer:src/sentry/seer/code_review/metrics.py: AddedNOT_SENTRY_CHECK_RUNto theWebhookFilteredReasonenum for better metric tracking.src/sentry/seer/code_review/webhooks/check_run.py(handle_check_run_event): An early check was added. Ifevent.check_run.external_idis empty or non-numeric, the webhook is now gracefully filtered usingrecord_webhook_filteredwith the newNOT_SENTRY_CHECK_RUNreason, and the function returns silently. This aligns the handling of these expected third-party payloads with other filtered webhook reasons.src/sentry/seer/code_review/webhooks/check_run.py(_validate_github_check_run_event): Theint()conversion ofexternal_idwas removed, as the upstream filter now handles non-numeric values. Theexceptclause was updated to only catchValidationError.This change reduces error noise by treating these third-party webhooks as expected, filtered events rather than exceptions.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes SENTRY-5KT4