ref(cells): Remove category from CellConfig#117558
Conversation
This property is no longer relevant, now that category is a property of Locality. Iwas previously only used to generate the `Locality.category` when creating a synthetic 1:1 cell. That behavior was removed in #117462.
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 422edcf. Configure here.
| def cell_display_order(cell: Cell) -> tuple[bool, bool, bool, str]: | ||
| return ( | ||
| cell.name != settings.SENTRY_MONOLITH_REGION, # default historical cell comes first | ||
| cell.category != RegionCategory.MULTI_TENANT, # multi-tenant before single |
There was a problem hiding this comment.
Staff cell sort regression
Low Severity
Staff-facing cells in client config dropped multi-tenant vs single-tenant ordering when Cell.category was removed, without using the locality’s category. Single-tenant cells may no longer sort after multi-tenant ones in the superuser cell list.
Reviewed by Cursor Bugbot for commit 422edcf. Configure here.
There was a problem hiding this comment.
category isn't a property of the cell anymore. I removed it rather than reimplement this to based on locality category since this is planned to be rewritten as discussed in #116895 (comment)
It also only applies to staff/superuser so is fairly inconsequential
2 participants
This property is no longer relevant, now that category is a property of Locality. Iwas previously only used to generate the
Locality.categorywhen creating a synthetic 1:1 cell. That behavior was removed in #117462.