fix(discover): Fix has:measurements.* queries
#78627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A measurement is nullable, but is not a column. The current logic falls through, and creates a string comparison condition. Since measurements are numeric, this fails in ClickHouse. Instead, queries for presence of a measurement should use a simple `"isNull"` condition.
github-actions
bot
added
the
Scope: Backend
JonasBa
approved these changes
Oct 5, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SENTRY-3DB9
We're seeing Snuba errors for comparisons of a numeric value to a string. e.g.,
Measurements are numeric, so this errors out. This comparison is created for queries like
has:measurements.frozen_frame_rate. That measurement is "synthetic", it's a function that divides two other measurements. It returns a numeric value, so comparison to string fails. The query builder's current logic doesn't account for measurement functions (i.e., plain measurements likemeasurements.lcpstill work), and creates the comparison incorrectly.The fix is to check for measurements, and return early with a basic check for null.