Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations): metrics for on-call integration SLOs #78660

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mifu67
Copy link
Contributor

@mifu67 mifu67 commented Oct 4, 2024

Add logging via EventLifecycle and EventLifecycleMetric to PagerDuty and Opsgenie.

Copy link

sentry-io bot commented Oct 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/integrations/opsgenie/client.py

Function Unhandled Issue
send_notification ApiUnauthorized: {"message":"Could not authenticate","took":0.007,"requestId":"78fc3a3b-c6fb-4804-826f-5486a12fed27"} ...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Oct 4, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/integrations/opsgenie/client.py 75.00% 1 Missing and 1 partial ⚠️
src/sentry/integrations/on_call/metrics.py 96.00% 1 Missing ⚠️
src/sentry/integrations/opsgenie/spec.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #78660   +/-   ##
=======================================
  Coverage   78.14%   78.14%           
=======================================
  Files        7100     7104    +4     
  Lines      312730   312802   +72     
  Branches    51074    51083    +9     
=======================================
+ Hits       244378   244451   +73     
- Misses      61977    61979    +2     
+ Partials     6375     6372    -3     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant