🔧 chore(discord): change rate limits to halt for SLOs #83656
+144
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
| lifecycle.add_extras( | ||
| { | ||
| "incident_id": incident.id, | ||
| "channel_id": channel, | ||
| } | ||
| ) | ||
| lifecycle.record_failure(error) | ||
| if isinstance(error, ApiRateLimitedError): |
There was a problem hiding this comment.
While I largely agree that this is a user-caused issue now, this might be problematic for users with larger orgs in the future if they decide to use the discord integration. We don't have to address this now, but we may want to consider having some mechanism to backlog and batch in the future (if possible).
Comment on lines
+81
to
+86
| responses.add( | ||
| method=responses.POST, | ||
| url=f"{DISCORD_BASE_URL}{MESSAGE_URL.format(channel_id=self.channel_id)}", | ||
| json={}, | ||
| status=200, | ||
| ) |
There was a problem hiding this comment.
Do we need this if the setup is already setting a mock response, and we're asserting that it's not called?
Comment on lines
90
to
92
| @mock.patch("sentry.integrations.utils.metrics.EventLifecycle.record_event") | ||
| def assert_lifecycle_metrics_halt_for_rate_limit(self, mock_record_event, mock_send_message): | ||
| assert_slo_metric(mock_record_event, EventLifecycleOutcome.HALTED) |
There was a problem hiding this comment.
I see this defined, but I don't see this used anywhere.
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #83656 +/- ##
========================================
Coverage 87.57% 87.58%
========================================
Files 9492 9492
Lines 539296 539414 +118
Branches 21219 21219
========================================
+ Hits 472310 472460 +150
+ Misses 66637 66605 -32
Partials 349 349 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one org has a extremely noisy alert (~4k fires in a single week) and its been severely ratelimited by discord. this however impacts our slos since we currently record rate limits as failures instead of halts.
also wrote some basic test cases for discord incident alert handler b/c we didn't have any 😬