feat(nav): Add initial SecondaryNav component #83687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Jan 17, 2025
Comment on lines
7
to
16
| const ref = useRef<HTMLDivElement>(null); | ||
| const {setSecondaryNavEl} = useNavContext(); | ||
|
|
||
| useEffect(() => { | ||
| if (ref.current) { | ||
| setSecondaryNavEl(ref.current); | ||
| } | ||
| }, [ref, setSecondaryNavEl]); | ||
|
|
||
| return <SecondarySidebarWrapper ref={ref} />; |
There was a problem hiding this comment.
i don't think refs trigger useEffects. You might be seeing the useMemo from the context trigger the useEffect at the right time. This will also set it to null on unmount
Suggested change
| const ref = useRef<HTMLDivElement>(null); | |
| const {setSecondaryNavEl} = useNavContext(); | |
| useEffect(() => { | |
| if (ref.current) { | |
| setSecondaryNavEl(ref.current); | |
| } | |
| }, [ref, setSecondaryNavEl]); | |
| return <SecondarySidebarWrapper ref={ref} />; | |
| const {setSecondaryNavEl} = useNavContext(); | |
| return <SecondarySidebarWrapper ref={setSecondaryNavEl} />; |
There was a problem hiding this comment.
Oh good call, this is much better
scttcper
reviewed
Jan 17, 2025
Comment on lines
+31
to
+33
| SecondaryNav.Body = function SecondaryNavBody({children}: {children: ReactNode}) { | ||
| return <Body>{children}</Body>; | ||
| }; |
There was a problem hiding this comment.
adding functions to a function object seems cursed
There was a problem hiding this comment.
that's javascript for ya
Bundle ReportChanges will increase total bundle size by 8.1kB (0.02%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
scttcper
approved these changes
Jan 23, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 29, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #84018
Adds the visual components and a story that will be added to as more work is done