chore: Tidy up node & config files including excepting them from import/no-nodejs-modules #83691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt/no-nodejs-modules
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
scttcper
reviewed
Jan 18, 2025
api-docs/index.ts
Outdated
| for (const [k, v] of Object.entries(dict)) { | ||
| res.push(`${k}: ${v}`); | ||
| } | ||
| return res.join('\n'); | ||
| } | ||
|
|
||
| function bundle(originalFile) { | ||
| const root = yaml.safeLoad(fs.readFileSync(originalFile, 'utf8')); | ||
| const root = yaml.load(fs.readFileSync(originalFile, 'utf8')); |
There was a problem hiding this comment.
i don't think the types we have installed match the version of js-yaml we're using
There was a problem hiding this comment.
i rolled back the safeload->load change, and some of the ts-ignores went away too.
scttcper
approved these changes
Jan 21, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Jan 22, 2025
…rt/no-nodejs-modules (#83691)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.