fix(taskworker) Align metric names and include taskname in more metrics #87787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add taskname tag to more worker metrics. We'll likely need to know how many instances of each task were added, and what the latency on each task is as well.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #87787 +/- ##
===========================================
+ Coverage 42.12% 87.76% +45.64%
===========================================
Files 9894 9913 +19
Lines 562283 563260 +977
Branches 22209 22129 -80
===========================================
+ Hits 236853 494356 +257503
+ Misses 325028 68502 -256526
Partials 402 402 |
john-z-yang
approved these changes
Mar 26, 2025
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
…cs (#87787) Add taskname tag to more worker metrics. We'll likely need to know how many instances of each task were added, and what the latency on each task is as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add taskname tag to more worker metrics. We'll likely need to know how many instances of each task were added, and what the latency on each task is as well.