chore(sentry apps): Add more context to sort through send webhook logs #87795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
cathteng
approved these changes
Mar 24, 2025
| { | ||
| "org_id": org_id, | ||
| "sentry_app_slug": sentry_app.slug, | ||
| "url": url or "", |
There was a problem hiding this comment.
i think it's ok if url is None or falsey for whatever reason
There was a problem hiding this comment.
;-; this addition was per mypy's insistence that extras can only take int | str
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently our logs for orgs that are sending bad webhooks is hard to aggregate with. I'm investigating if there are outlier orgs that are spamming bad webhooks causing the queue to backlog. Adding some fields here so I can aggregate the logs better