ref(tour): Remove isAvailable state #87805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
malwilley
force-pushed
the
malwilley/ref/tour-is-available
branch
from
a5b6f79 to
782552d
Compare
scttcper
approved these changes
Mar 24, 2025
leeandher
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While refactoring part of the tour state to include callbacks, I realized that
isAvailabledoesn't actually need to be stateful. To me it makes more sense to control this from outside the tour component. I can't find any reason for why it needs to be part of the component state, but let me know if I'm missing something.For issue details I extracted the logic into
useIssueDetailsTourAvailable()which is used to determine whether or not to start the tour.