ref(aci): tagged event and event attribute subfilters for event frequency conditions #87807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt frequency conditions
github-actions
bot
added
the
Scope: Backend
cathteng
commented
Mar 24, 2025
Comment on lines
+365
to
+368
| case EventAttributeFilter.id: | ||
| comparison_filter["attribute"] = condition["attribute"] | ||
| case TaggedEventFilter.id: | ||
| comparison_filter["key"] = condition["key"] |
There was a problem hiding this comment.
these two conditions only differ in that one has an attribute key and the other one has key, and we'll need to query snuba differently
There was a problem hiding this comment.
feels so weird to have a switch statement (match) but not have to worry about fall through from the cases. haha
saponifi3d
approved these changes
Mar 25, 2025
Comment on lines
+365
to
+368
| case EventAttributeFilter.id: | ||
| comparison_filter["attribute"] = condition["attribute"] | ||
| case TaggedEventFilter.id: | ||
| comparison_filter["key"] = condition["key"] |
There was a problem hiding this comment.
feels so weird to have a switch statement (match) but not have to worry about fall through from the cases. haha
cathteng
deleted the
cathy/aci/save-slow-condition-subfilters-separately
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Mar 27, 2025
…ency conditions (#87807)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event frequency conditions that query Snuba will also include additional query filters for tags and event attributes.
The tag filter is currently implemented -- this queries the
tagscolumn in Snuba for thematchand thevalue.However, for event attributes, each attribute is a separate Snuba column that we need to query separately for the
matchandvalue.This PR prepares for querying each event attribute filter separately by storing the event attribute filter differently from tagged event filter, using each filter's respective
comparison_json_schema.