Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(insights): add give feedback section to session health tab #87808

Merged
merged 4 commits into from
Mar 25, 2025

Conversation

michellewzhang
Copy link
Member

@michellewzhang michellewzhang commented Mar 24, 2025

adds a feedback section to the session health tabs for mobile & frontend next to the bottom row of charts:

Screen.Recording.2025-03-24.at.3.18.29.PM.mov

@michellewzhang michellewzhang requested a review from a team as a code owner March 24, 2025 22:07
@michellewzhang michellewzhang requested review from a team and jas-kas March 24, 2025 22:07
@michellewzhang michellewzhang changed the title feat(insights): add feedback section to session health tab feat(insights): add give feedback section to session health tab Mar 24, 2025
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 24, 2025
@@ -42,8 +42,6 @@ export function SessionsOverview() {
const hasSessionData = useProjectHasSessions();
const showOnboarding = !hasSessionData;

useRouteAnalyticsParams({view});
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this, i was mistaken

Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@michellewzhang michellewzhang merged commit 44dd10e into master Mar 25, 2025
40 checks passed
@michellewzhang michellewzhang deleted the mz/add-feedback-button branch March 25, 2025 17:18
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
adds a feedback section to the session health tabs for mobile & frontend
next to the bottom row of charts:



https://github.com/user-attachments/assets/07bb5942-0fbd-45e7-b09c-dc23d45307fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants