-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(partnerships): backend service for partnership methods #87817
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #87817 +/- ##
========================================
Coverage 87.73% 87.74%
========================================
Files 9925 9930 +5
Lines 563897 564240 +343
Branches 22208 22208
========================================
+ Hits 494761 495077 +316
- Misses 68734 68761 +27
Partials 402 402 |
96373a4
to
f3489b5
Compare
The format is typed here in Sentry: sentry/src/sentry/relay/types/generic_filters.py Lines 7 to 12 in f33c41c
The filter itself is in the tech spec and added as a test in Relay. Actually testing if the filter works is currently not possible, I think testing that the filter is added to the config should be sufficient. But it may make sense to add the filter in a separate PR and then hide it behind a feature flag/options automator option to control the rollout. |
There isn't much to test yet. I think the tests will come with the getsentry implementation. When you are connecting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what david said (testing that the filter is added in the expected cases) makes sense and that your tests right now are sufficient for what we currently have
94f45f4
to
c85de82
Compare
c85de82
to
5a7bc25
Compare
So please go ahead and review this and getsentry side of it. After merging these I add it to the project config code and add the tests there. |
This PR is milestone 2 of this tech spec, Sentry side: https://www.notion.so/sentry/Nintendo-inbound-filter-1b58b10e4b5d80dc9090ec64d2825349?pvs=4#1ba8b10e4b5d802ba55fc0313f98f6cd
Getsenrty implementation: https://github.com/getsentry/getsentry/pull/17033
In the next PR I'll add it to project config code.