Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(issue summary): Refactor issue summary to make logic reusable #87822

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

roaga
Copy link
Member

@roaga roaga commented Mar 25, 2025

Making issue summary logic reusable in preparation for triggering from alerts. Should not affect functionality.

@roaga roaga requested a review from jennmueng March 25, 2025 00:02
@roaga roaga requested a review from a team as a code owner March 25, 2025 00:02
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 93.04348% with 24 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/sentry/seer/issue_summary.py 79.83% 24 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #87822   +/-   ##
=======================================
  Coverage   87.76%   87.76%           
=======================================
  Files        9907     9909    +2     
  Lines      562666   562713   +47     
  Branches    22128    22128           
=======================================
+ Hits       493837   493893   +56     
+ Misses      68398    68389    -9     
  Partials      431      431           

@roaga roaga force-pushed the issue-summary/refactor branch from 187331b to 7aa580c Compare March 25, 2025 16:51
@roaga roaga merged commit a05d27f into master Mar 25, 2025
47 checks passed
@roaga roaga deleted the issue-summary/refactor branch March 25, 2025 17:21
Copy link

sentry-io bot commented Mar 25, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎

kddubey added a commit that referenced this pull request Mar 27, 2025
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
…7822)

Making issue summary logic reusable in preparation for triggering from
alerts. Should not affect functionality.
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants