Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(shared-views): Don't normalize "All Projects" on the frontend #87824

Merged

Conversation

MichaelSun48
Copy link
Member

This frontend PR is a follow up this backend PR — the frontend no longer sends or expected an isAllProjects parameter, and it doesn't worry about normalizing projects=[-1] to projects=[] and isAllProjects=True since that logic has been moved to the backend.

@MichaelSun48 MichaelSun48 requested a review from a team as a code owner March 25, 2025 01:02
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
10005 1 10004 15
View the full list of 1 ❄️ flaky tests
provisionSubscriptionAction calls api with correct am3 dynamic sampling args

Flake rate in main: 22.22% (Passed 14 times, Failed 4 times)

Stack Traces | 5.05s run time
Error: thrown: "Exceeded timeout of 5000 ms for a test.
Add a timeout value to this test to increase the timeout, if this is a long-running test. See https://jestjs.io/docs/api#testname-fn-timeout."
    at .../gsAdmin/components/provisionSubscriptionAction.spec.tsx:953:3
    at _dispatchDescribe (.../jest-circus/build/index.js:91:26)
    at describe (.../jest-circus/build/index.js:55:5)
    at Object.<anonymous> (.../gsAdmin/components/provisionSubscriptionAction.spec.tsx:14:1)
    at Runtime._execModule (.../jest-runtime/build/index.js:1439:24)
    at Runtime._loadModule (.../jest-runtime/build/index.js:1022:12)
    at Runtime.requireModule (.../jest-runtime/build/index.js:882:12)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:77:13)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
    at Object.worker (.../jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@MichaelSun48 MichaelSun48 requested a review from malwilley March 25, 2025 16:38
@MichaelSun48 MichaelSun48 merged commit c5ffa7e into master Mar 25, 2025
41 checks passed
@MichaelSun48 MichaelSun48 deleted the msun/issueViews/dontNormalizeProjectsOnFrontend branch March 25, 2025 17:15
andrewshie-sentry pushed a commit that referenced this pull request Mar 27, 2025
…7824)

This frontend PR is a follow up [this backend
PR](#87767) — the frontend no
longer sends or expected an `isAllProjects` parameter, and it doesn't
worry about normalizing `projects=[-1]` to `projects=[]` and
`isAllProjects=True` since that logic has been moved to the backend.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants