impr(jira): switch to paginated project endpoint for jira issue config #89707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #89707 +/- ##
===========================================
+ Coverage 42.11% 87.68% +45.56%
===========================================
Files 10216 10213 -3
Lines 575535 576222 +687
Branches 22719 22685 -34
===========================================
+ Hits 242400 505272 +262872
+ Misses 332692 70516 -262176
+ Partials 443 434 -9 |
Christinarlong
commented
Apr 16, 2025
leeandher
reviewed
Apr 17, 2025
leeandher
reviewed
Apr 17, 2025
GabeVillalobos
approved these changes
Apr 18, 2025
Comment on lines
+831
to
+839
| projects_form_field = { | ||
| "name": "project", | ||
| "label": "Jira Project", | ||
| "choices": [(p["id"], f"{p["key"]} - {p["name"]}") for p in jira_projects], | ||
| "default": meta["id"], | ||
| "type": "select", | ||
| "updatesForm": True, | ||
| "required": True, | ||
| } |
There was a problem hiding this comment.
Part of the "leaving code better than we found it" mantra, it'd be nice if we could create a typeddict or dataclass for this in the future.
There was a problem hiding this comment.
do you mind if I pull out the FormField typing to another PR ? It's going to add a lot of changes unrelated to the original PRs goal.
There was a problem hiding this comment.
moving formfield typing to another PR
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Christinarlong
added
the
Trigger: Revert
|
PR reverted: 13efe59 |
getsentry-bot
added a commit
that referenced
this pull request
Apr 18, 2025
…ue config (#89707)" This reverts commit 515d2a1. Co-authored-by: Christinarlong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on FF: #89709
Addresses: TRI-123
For getting the Jira issue config, switch to using the paginated endpoint for getting projects. O also added a QOL so we'll display the label with both the Jira project key and project name. Docs for Jira search/paginated projects endpoint
Flow:
Initial load (max 10 projects)
Search load
