-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: replace python-jose with pyjwt #6757
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any way to test this functionality?
Totally missed adding my tests to the git commit. One sec. |
We have #6749 to increase the coverage through tests but can you please make sure that snuba admin is not broken after this change? |
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
#6739
Take two of replacing python-jose with PyJWT. I did not include the cryptography dependency in the previous PR which lead to an
InvalidAlgorithmError
exception.