Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(admin): Add a standardized component for copying query results #6789

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

evanh
Copy link
Member

@evanh evanh commented Jan 17, 2025

At lot of components offer the ability to copy the results of a run query, but each had a slightly
different way of providing that functionality. That meant that not all functionality across the
components.

Add a standard component for these buttons. This will also ensure that system queries now have a
CSV copy results.

Screenshot 2025-01-17 at 3 41 35 PM

Resolves #6751

@evanh evanh requested a review from a team as a code owner January 17, 2025 20:42
At lot of components offer the ability to copy the results of a run query, but each had a slightly
different way of providing that functionality. That meant that not all functionality across the
components.

Add a standard component for these buttons. This will also ensure that system queries now have a
CSV copy results.
@evanh evanh force-pushed the evanh/feat/query-result-admin-class branch from ee10d47 to 3062ccf Compare January 17, 2025 20:42
Copy link
Member

@volokluev volokluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful

Copy link
Member

@onkar onkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow copying CSV results from ClickHouse system table through snuba admin
3 participants