-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wip(store): Shard sqlite #242
base: main
Are you sure you want to change the base?
Conversation
238224f
to
0cd1a6c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #242 +/- ##
==========================================
+ Coverage 83.35% 83.95% +0.60%
==========================================
Files 19 19
Lines 3568 3833 +265
==========================================
+ Hits 2974 3218 +244
- Misses 594 615 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
630794a
to
e2a2ca4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👏
.into_iter() | ||
.collect::<Result<Vec<_>, _>>()? | ||
.into_iter() | ||
.sum()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These combinator chains 🤩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we actually might not need these join_all operation since most of them are for upkeep
, and we could just run a single upkeep per shard.
4273e57
to
3ae60ef
Compare
3ae60ef
to
dc4112c
Compare
f3e38f1
to
83979f2
Compare
main
john/shard-store